Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements tizen platform #692

Merged
merged 29 commits into from
Nov 8, 2022
Merged

Implements tizen platform #692

merged 29 commits into from
Nov 8, 2022

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Oct 14, 2022 •
edited by brminnick
Loading

Description of Change

  • This PR implements handlers for tizen platform
  • I have to update maui versions at least 6.0.540 because on 6.0.540 had a big changes on Tizen handlers. So I update 6.0.312.json to 6.0.541.json
  • I'm not sure main branch is a best place to put this PR. if I should it put another branch, please let me know.
  • I hope to Tizen handlers are shiped with maui 6.x versions. because many apps build this maui 6.x versions and tizen also need it
  • Tizen platform include on TargetFrameworks when only if current os platform is windows and it run on CI(TF_BUILD)

Linked Issues

PR Checklist

Additional information

image
image
image

@VladislavAntonyuk
Copy link
Collaborator

Thank you @myroot. What do you think if we merge it together with net7?

@VladislavAntonyuk VladislavAntonyuk added the hacktoberfest-accepted A PR that has been approved during Hacktoberfest label Oct 14, 2022
@rookiejava
Copy link

rookiejava commented Oct 14, 2022 •
edited
Loading

Thank you @myroot. What do you think if we merge it together with net7?

Since the latest version(7.0) of Tizen platform/products are compatible with net6, so we hope to be included in net6 as a high prioprity. After that, It is also good to merge into net7.

Is there no plan to release a new version of MauiCommunityToolkit for net 6?

Thanks!

VladislavAntonyuk
VladislavAntonyuk requested changes Oct 14, 2022
View reviewed changes
src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.tizen.cs Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/DrawingView/Service/DrawingViewService.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/DrawingView/Service/DrawingViewService.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Show resolved Hide resolved
src/CommunityToolkit.Maui/Alerts/Snackbar/Snackbar.tizen.cs Outdated Show resolved Hide resolved
@VladislavAntonyuk
Copy link
Collaborator

VladislavAntonyuk commented Oct 14, 2022 •
edited
Loading

Is there no plan to release a new version of MauiCommunityToolkit for net 6?

We are going to release it with net 6. It will be the last version based on net6. The next major version (2.0) will be based on net 7. Most likely we will not add fixes for version 1.0 (net6.0)

@myroot
Copy link
Contributor Author

myroot commented Oct 15, 2022

@VladislavAntonyuk , Thanks for review, I update the code according to your review

@myroot myroot force-pushed the add-tizen-handlers branch from 9f9d2a3 to 90d9000 Compare October 15, 2022 03:39
pictos
pictos reviewed Oct 15, 2022
View reviewed changes
6.0.541.json Outdated Show resolved Hide resolved
pictos
pictos requested changes Oct 15, 2022
View reviewed changes
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @myroot this is really impressive, thanks for all that! I've a couple of questions and suggestions.

src/CommunityToolkit.Maui.Core/Handlers/Popup/PopupHandler.tizen.cs Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui/Alerts/Snackbar/Snackbar.tizen.cs Outdated Show resolved Hide resolved
@VladislavAntonyuk @pictos
Update src/CommunityToolkit.Maui/Alerts/Snackbar/Snackbar.tizen.cs
e212b87 
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
@myroot
Copy link
Contributor Author

myroot commented Oct 16, 2022

@pictos Thanks for review, I updated all things mentioned by review

VladislavAntonyuk
VladislavAntonyuk reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempt to use 6.0.300

brminnick
brminnick previously approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myroot!

For the next step in the New Feature Proposal process, we ask the contributor to update the official .NET MAUI Community Toolkit docs.

I'm not sure how many features include platform-specific docs, but it'll be a good idea to read through the docs for all of the new *.tizen.cs (eg Popup, DrawingView, StatusBar, etc.) to add all necessary Tizen info.

You'll certainly want to update the Supported Platform information to include Tizen 💯

You can find the open-source repo for the docs here: https://github.com/MicrosoftDocs/CommunityToolkit

@JoonghyunCho - Do you mind helping @myroot with the docs?

@brminnick brminnick requested a review from pictos October 21, 2022 02:32
@JoonghyunCho JoonghyunCho mentioned this pull request Oct 21, 2022
Merged
pictos
pictos requested changes Oct 23, 2022
View reviewed changes
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I believe we're almost there... I just a few more requirements, let me know if you've any question.

Directory.Build.props Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Handlers/Popup/PopupHandler.tizen.cs Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/DrawingView/Service/DrawingViewService.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Maui.Core/Views/Popup/MauiPopup.tizen.cs Outdated Show resolved Hide resolved
...mmunityToolkit.Maui/Behaviors/PlatformBehaviors/SelectAllText/SelectAllTextBehavior.tizen.cs Outdated Show resolved Hide resolved
@myroot myroot force-pushed the add-tizen-handlers branch from b4846f2 to 91e9cc7 Compare October 24, 2022 06:33
@JoonghyunCho JoonghyunCho added the needs discussion Discuss it on the next Monthly standup label Oct 31, 2022
@JoonghyunCho
Copy link
Member

Sharing how the community toolkit looks on Tizen https://github.com/JoonghyunCho/CommunityToolkit.Maui/wiki

@brminnick brminnick added this to the v2.0.0 milestone Nov 3, 2022
@VladislavAntonyuk VladislavAntonyuk removed the needs discussion Discuss it on the next Monthly standup label Nov 7, 2022
pictos
pictos approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using my powers to unblock this!

@brminnick brminnick mentioned this pull request Nov 8, 2022
Closed
@JoonghyunCho JoonghyunCho merged commit e80192b into CommunityToolkit:main Nov 8, 2022
@brminnick brminnick mentioned this pull request Nov 9, 2023
Merged
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoonghyunCho JoonghyunCho JoonghyunCho left review comments

@rookiejava rookiejava rookiejava left review comments

@pictos pictos pictos approved these changes

@VladislavAntonyuk VladislavAntonyuk VladislavAntonyuk left review comments

@brminnick brminnick brminnick left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted A PR that has been approved during Hacktoberfest
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[Proposal] Support Tizen
6 participants
@myroot @VladislavAntonyuk @rookiejava @brminnick @JoonghyunCho @pictos